go-ipfs sometimes closes the stream preemptively

[daviddias]

From: #337 (comment)

---

Ok, I thought I had fixed the adding dirs on the browser, but then realised that there is a bug that only happens sometimes (like 1 out of 20), where we don't receive all the hashes for the files added.

I thought this could be an js-ipfs-api problem, but further testing (and some fixes) narrowed down the problem to how go-ipfs is responding, even when requests are 100% the same, the response may differ.

The failing failing test is: https://github.com/ipfs/interface-ipfs-core/blob/feat/ipfs.files.get/src/files.js#L113-L143 (again: just fails in the browser and some of the times)

(left -> success; center -> fails)

Full request + response of a Success
Full request + response of a Failure
wireshark pcap (filter for HTTP and then look for the POST /add

How to reproduce

> git clone git@github.com:ipfs/interface-ipfs-core.git -b feat/ipfs.files.get 
> cd interface-ipfs-core
> npm i && npm run build && npm link
> cd ..
> git clone git@github.com:ipfs/js-ipfs-api.git -b feat/ipfs.files.get
> cd js-ipfs-api 
> npm i && npm link interface-ipfs-core
> npm run test:browser # repeat this one till it fails

[whyrusleeping]

@diasdavid @dignifiedquire could you find a way to reproduce this with a simple curl command? I guess i'm just not very good at javascript but i have trouble even getting these tests to run, consistently hitting new and exciting problems.

[daviddias]

After we talked and you getting the test to run, are you still getting that issue?

[whyrusleeping]

apparently i just needed to rerun it a few times for the tests to run. I was having issues with karma and chrome, but a few more tries and it started running the tests.

[whyrusleeping]

A relevant note: this has only been reproduced in the browser testing.

[whyrusleeping]

might be related to: ipfs/kubo#2112

Which i can only reproduce using ipfs 0.4.2 or earlier.

[daviddias]

Still seeing the same problem in 0.4.3.

[whyrusleeping]

@diasdavid thanks for checking.

[daviddias]

@whyrusleeping anything else I can do to help with this bug?

[daviddias]

Any developments?