This repository was archived by the owner on Mar 10, 2020. It is now read-only.
chore: add tests timeouts as they were previously #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PedroMiguelSS
force-pushed
the
chore/update-tests-timeouts
branch
5 times, most recently
from
660741f to
dcbbb9e
Compare
PedroMiguelSS
force-pushed
the
chore/update-tests-timeouts
branch
7 times, most recently
from
8fd0c8d to
98d6b97
Compare
achingbrain
suggested changes
Dec 6, 2019
PedroMiguelSS
force-pushed
the
chore/update-tests-timeouts
branch
from
98d6b97 to
36e9749
Compare
We previously set this node up and attempted to dial it without a relay node being present which failed and we accidentally-on-purpose ignored the error by resolving a promise with an error instead of rejecting it. The test does not assert anything to do with the other node, and the `allowOffline` option should allow us to publish IPNS names without having any peers so the other node is redundant and can be removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
timeoutsas they were before the async/await refactor.