This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Added in a test for the opts parameter. #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The opts parameter wasn't correctly passed in when calling ipfs.object.stat. This is the test that makes sure opts is being correctly passed to through the send function to the IPFS daemon. I've also removed the "base58" encoding that was being passed in for some tests as base58 isn't a valid option for encoding and would provide this error: Uncaught AssertionError: expected [Error: invalid encoding: base58] to not exist
1 task
alanshaw
suggested changes
Jul 26, 2019
There was a problem hiding this comment.
❤️ Looks good, I have just a few tweaks and could you also please fix up the linting errors? https://travis-ci.com/ipfs/interface-js-ipfs-core/builds/120783875 🙏
Co-Authored-By: Alan Shaw <[email protected]>
Co-Authored-By: Alan Shaw <[email protected]>
Co-Authored-By: Alan Shaw <[email protected]>
alanshaw
reviewed
Jul 26, 2019
|
@alanshaw all linting changes have been made and everything you've commented on should be resolved. |
alanshaw
approved these changes
Jul 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opts parameter wasn't correctly passed in when calling ipfs.object.stat. This is the test that makes sure opts is being correctly passed to through the send function to the IPFS daemon.
I've also removed the "base58" encoding that was being passed in for some tests as base58 isn't a valid option for encoding and would provide this error:
Uncaught AssertionError: expected [Error: invalid encoding: base58] to not exist