This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Enable peer listing tests #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haadcode
force-pushed
the
fix/pubsub-tests
branch
from
d5c5fc8 to
336cf32
Compare
|
awesome! Can I get a confirmation that js-ipfs is still happy with these tests? It was before, but always run the tests again to be sure. |
daviddias
approved these changes
Mar 7, 2017
|
Update: haven't been able to check this yet but will do so at some point this week (as soon as I'm done with the pending Orbit release). |
daviddias
force-pushed
the
fix/pubsub-tests
branch
from
336cf32 to
11724e4
Compare
|
Thank you @haadcode, understand that you have a busy week ahead. If you don't mind, I'll just go ahead and test it myself. |
|
yep, seems fine in js-ipfs master :) merging! |
|
Thank you! 🎉 ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enable previously the skipped tests for pubsub.peers().