Commit e45c1f3
committed
fix: Make position embedding optional for split GGUF
Critical fixes for split GGUF models:
1. Position embedding made OPTIONAL:
- Split GGUF models lack v.pos_embed.weight
- Dimension mismatch (768 vs 1152) makes it unusable
- Now skipped gracefully instead of failing ensureVisionReady
2. Defensive nil check in VisionPositionEmbedding.Forward:
- Returns hiddenStates unchanged if PositionEmbedding is nil
- Prevents panic in split GGUF path
3. RoPE provides positional info in attention layers
- Position embedding not critical for Qwen3-VL
- M-RoPE in attention handles spatial/temporal positions
This should allow split GGUF to proceed past ensureVisionReady.1 parent 25ef4f6 commit e45c1f3
File tree
3 files changed
+11
-3
lines changed- Z_Iosu/logs
- model/models/qwen3vl
3 files changed
+11
-3
lines changedBinary file not shown.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
126 | | - | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
127 | 130 | | |
128 | | - | |
129 | 131 | | |
130 | 132 | | |
131 | 133 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
166 | 172 | | |
167 | 173 | | |
168 | 174 | | |
| |||
0 commit comments