fix(icon): verify the icon loads in the lifecycle #1278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
approved these changes
Sep 12, 2023
mapsandapps
approved these changes
Sep 12, 2023
Contributor
mapsandapps
left a comment
mapsandapps
left a comment
There was a problem hiding this comment.
Looks good! Thanks for finding & fixing this
liamdebeasi
added a commit
that referenced
this pull request
Nov 20, 2023
This reverts commit 7f7f346.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue URL: N/A
What is the current behavior?
Icons won't load when using Angular binding.
What is the new behavior?
Icons now load when using Angular binding.
Does this introduce a breaking change?
Other information
N/A