fix(angular): make route observables available on constructor #17914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You sir, hats off to you my friend! |
mhartington
approved these changes
Apr 1, 2019
kiku-jw
pushed a commit
to kiku-jw/ionic
that referenced
this pull request
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
The fix introduced in #17888 also broke certain expectations as observables on ActivatedRoute were no longer available at the constructor but only after ngOnInit, this could cause many breaking changes for users that expect to use the observables as they would in a vanilla angular app.
Changes proposed in this pull request:
Ionic Version: 4.x
Fixes: