Skip to content

fix(deeplinker): account for base href in deep linker #12941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 144 commits into from
Closed

fix(deeplinker): account for base href in deep linker #12941

wants to merge 144 commits into from

Conversation

soumak77
Copy link
Contributor

@soumak77 soumak77 commented Sep 20, 2017 •
edited
Loading

use APP_BASE_HREF when generating urls from within deep linker

fixes #12983

brandyscarney and others added 30 commits June 12, 2017 13:51
@brandyscarney
style(util): remove commented out test css
a91a68e
@Manduro @manucorporat
fix(refresher): border should only show when pulled (#12015)
47e3c70 
fixes #10994
@manucorporat
fix(keyboard): big keyboard/input refactor
c10f72b 
fixes #9699
fixes #11484
fixes #11389
fixes #11325
fixes #11291
fixes #10828
fixes #11291
fixes #10393
fixes #10257
fixes #9434
fixes #8933
fixes #7178
fixes #7047
fixes #10552
fixes #10393
fixes #10183
fixes #10187
fixes #10852
fixes #11578
@manucorporat
Merge branch 'keyboard-fixes'
6dee17b
@manucorporat
fix(input): add correct translate3d for rtl
ef85ba6 
thanks @Khalid-Nowaf

fixes #11745
fixes #11211
@Manduro @manucorporat
fix(input): use all supported attributes on both textareas and inputs (…
8041eed 
…#12028)
@manucorporat
fix(input): better handling of attributes
9f86e10
@manucorporat
fix(textarea): apply classes properly
dc958c3
@Manduro @manucorporat
fix(input): slightly longer delay for autofocus (#12037)
54ac2e3
@danbucholtz
chore(changelog): 3.4.0 release
2791c40
@danbucholtz
chore(dependencies): update package version to 3.4.0
f149c5e
@danbucholtz
chore(github): update issue template plunkr to 3.4.0 version
3564bcf
@manucorporat
fix(input): prevent duplicated tabIndex (#12043)
7a1342c 
fixes #7178
@manucorporat
refactor(overlay): simplify focusOutActiveElement (#12023)
2743c63
@zakton5 @manucorporat
feat(select): add compareWith Input for object value comparison (#11965)
c7645ee 
fixes #6625
@manucorporat
fix(highlight): selected tab might be null
5a5da39 
fixes #12054
@danbucholtz
chore(changelog): add upgrade instructions for 3.4.0
1a4aacf
@manucorporat
fix(sliding-item): super slow device does get correct classes
6193560 
fixes #11988
@AmitMY @manucorporat
feat(item-reorder): add side support (#11642)
63f728f 
fixes #11637
@manucorporat
perf(item): button-effect is hidden for non buttons
8bd2f24
@manucorporat
style(reorder): using const
7803998
@dudeofawesome @manucorporat
fix(tabs): properly align tabs highlight (#11619)
a8731df 
When `Tabs` are nested within each other, the highlight can get
misaligned. This prevents that by ensuring the affected
`.tab-highlight` is a direct child of the targeted `Tabs`.
@danbucholtz
chore(changelog): fix typo, update deps to latest
877d821
@brandyscarney
fix(themes): change default app-direction
1ca7df7
@brandyscarney
chore(ionic): release 3.4.1
5094fee
@brandyscarney
fix(rtl): use multi direction in order to override the default ltr
70b5b6b
@brandyscarney
chore(ionic): release 3.4.2
d8b65da
@manucorporat
fix(select): floating label
e3a8d27 
fixes #12068
@danbucholtz
feature(navigation): modify urls to support multiple root level navs/…
5cad965 
…tabs

* wip

* wip

* progress

* wippy skippy

* getting there

* all tests passing except goBack

* unit tests pass again boi

* goBack tests pass

* great success

* the good stuff
@danbucholtz
chore(build): strictly enforce metadata
00fbded
@soumak77 soumak77 mentioned this pull request Sep 26, 2017
Closed
danielsogl and others added 14 commits September 25, 2017 20:59
@danielsogl @kensodemann
docs(keyboard): cosmetically improve documentation (#12969)
a48d02a
@danielsogl @kensodemann
docs(ionic-error-handler): cosmetically improve documentation (#12968)
794d88d
@danielsogl @kensodemann
docs(haptic): cosmetically improve documentation (#12966)
8621075
@danielsogl @kensodemann
docs(events): cosmetically improve documentation (#12965)
c7b2b18
@danielsogl @kensodemann
docs(alert-controller): use const instead of let (#12964)
b248eb7
@danielsogl @kensodemann
docs(action-sheet-controller): use const instead of let (#12963)
66faa1d
@danielsogl @kensodemann
docs(toast-controller): use const instead of let (#12962)
200fa93
@kensodemann
docs(slides): clarify how zooming works (#12932)
b5bfda2 
fixes #12861
@danielsogl @kensodemann
docs(nav-params): cosmetically improve documentation (#12972)
4e56458
@danbucholtz
chore(dependencies): update to latest angular
9b5c0e0
@danbucholtz
chore(dependencies): revert to ts 2.3.x
f42e81b
@mhartington
feat(): initial iphoneX support
112d4f5 
* feat(cordova): add ios11 safeAreaInsets support

* feat(cordova): ios11 padding mixin

* chore(dependencies): go to angular 4.1.3

* chore(build): temporarily disable git pull and status from master as part of build

* fix(sass): add a mixin for the safe-area-padding

* style(sass): fix sass lint errors

* style(): tabs, footer, content changes

* fix(): lint

* style(sass): fix sass linter error

* refactor(footer): use safe area for all modes

* fix(tabs): increase font-weight of tabs for iOS 11

* style(): fix content padding and sizing

* style(sass): fix linter and remove unused vars

* style(): actionsheet, toast, header updates

* fix(): sass lint

* chore(): backout release changes

* chore(): update to lastest master
@mhartington
chore(): fix gulp task
eacc5d4
@soumak77
Merge branch 'ionic-team/master' into fix-base-href
bb0f482
@kensodemann kensodemann added this to the 3.9.0 milestone Oct 27, 2017
@kensodemann
Copy link
Member

Added @danbucholtz as a reviewer to have a look at this and respond one way or another for our 3.9.0 release milestone.

@soumak77
Copy link
Contributor Author

@danbucholtz any update on this?

@kensodemann kensodemann removed this from the 3.9.0 milestone Nov 30, 2017
@Ionitron
Copy link
Collaborator

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!

@Ionitron Ionitron closed this Mar 12, 2018
@soumak77
Copy link
Contributor Author

soumak77 commented Apr 9, 2018

This PR has been resubmitted for the v3 branch: #14296

@ionitron-bot ionitron-bot bot mentioned this pull request Nov 28, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbucholtz danbucholtz Awaiting requested review from danbucholtz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deep-linker does not account for base href when using path strategy