[4.0.0-beta.17] routerLink not working after first successful forward/back navigation

[h4rm]

Bug Report

Ionic Info

Ionic:

   ionic (Ionic CLI)             : 4.4.0 (/Users/ben/.nvm/versions/node/v10.13.0/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.0-beta.17
   @angular-devkit/build-angular : 0.11.0
   @angular-devkit/schematics    : 7.1.0
   @angular/cli                  : 7.1.0
   @ionic/angular-toolkit        : 1.2.0

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : none
   Cordova Plugins       : no whitelisted plugins (0 plugins total)

System:

   ios-deploy : 1.9.2
   ios-sim    : 5.0.6
   NodeJS     : v10.13.0 (/Users/ben/.nvm/versions/node/v10.13.0/bin/node)
   npm        : 6.4.1
   OS         : macOS
   Xcode      : Xcode 9.4.1 Build version 9F2000

Describe the Bug
After navigating to another route with routerLink (e.g. relative navigation in tabs via ['../', 'session', session.id]) and after going back via ionic back button, which works as intended, the original routerLink is not working anymore.

Steps to Reproduce
Steps to reproduce the behavior:

1. Clone ionic-conference-app
2. (Change @ionic/angular to beta17)
3. in schedule.html of the schedule, switch href with [routerLink]="['../', 'session', session.id]"
4. Navigate to session detail and back, try again

Expected Behavior
Navigation should still work.
Maybe this has to do with your recent changes @manucorporat.

[eduboxgithub]

I also found this bug.

It also happens when you navigate to a details page with NavController ou event the Angular Router (router.navigate()).

For example:
this.NavController.navigateForward(['../details', item.id], true, { relativeTo: this.ActivatedRoute })

When you press the back button on details page it goes back, but you cannot navigate anymore to the details page.

I started a new sidemenu project, added a details page and linked a click event to a button on a item from the list. This navigation one happens once.

You can download the source to test it: https://bit.ly/2FQKiWc

[manucorporat]

Does it work in beta.16?

[h4rm]

No. But I think the same problem appeared in Beta15. Manu MA <notifications@github.com> schrieb am Fr., 30. Nov. 2018, 20:08:

…

Does it work in beta.16? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#16534 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiwzhiV48PUlDdifYp7ZK81qxB8o9BIks5u0YI7gaJpZM4Y7SC4> .

[eduboxgithub]

I thought it was working in the previous versions, because I was using the Angular Router directly.

But when I upgraded to beta17 I had to change to NavController to force some programmatic routerDirection and setRoot (Angular Router has only making push) and I noticed the bug. I rollback to the Beta16 and I noticed the bug was still there when using the NavController.

[codeinpink]

For other people facing this issue, navigateByUrl still works -- at least in beta.15.

[eduboxgithub]

I'm getting a little confuse with this bug, and I'm sorry to put this question here, but on a Ionic 4 app Am I suppose to use the Angular Router or the NavController?

If I use the Router I will not get transitions and "setRoot"/"push" concepts?
So, should I use NavController instead?
The NavController will be kept in the final release? (I read somewhere it will probably not).

[eduboxgithub]

I made a few more tests.

This call recreates the reported problem:
this.NavController.navigateForward(['../details', user.IdUser], { relativeTo: this.ActivatedRoute })

This one not. It works in beta16 and beta17.
this.NavController.navigateForward(['users/details', user.IdUser], true);

[manucorporat]

relative paths seems to break, i have already spent 3 days trying to debug this without success. I would recommend to avoid using relative paths

[h4rm]

Hey Manu, thanks for your time and effort. Sorry to hear that it is such a hassle.

We use relative routes for opening the same (detail) page in different tabs and maintaining the navigation history in each tab. Modifying the links in each tab on-the-fly involves reimplementing what angulars router basically solves for you, I'd rather not do that ;)
I'll try to also look into the issue further, maybe I can dig up the culprit.
Cheers everyone.

[eduboxgithub]

Also noticed another problem.

When on a details page and a if the previous page had query params, the query params are "lost".

Example:
http://localhost:8100/user/list?idmenu:1 (details button pressed)
http://localhost:8100/user/details/1 (back button (back button visible with navigationFoward) pressed)
http://localhost:8100/user/list

I would expect to get the previous URL http://localhost:8100/user/list?idmenu:1 and not http://localhost:8100/user/list.