Skip to content

Commit d60ffc1

Browse files
committed
chore(): do not use cypress gh action
1 parent bb2e3e9 commit d60ffc1

File tree

4 files changed

+34
-16
lines changed

4 files changed

+34
-16
lines changed

.github/workflows/actions/test-react-e2e/action.yml

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,19 @@ runs:
2929
name: ionic-react-router
3030
path: ./packages/react-router
3131
filename: ReactRouterBuild.zip
32-
- uses: cypress-io/github-action@v2
33-
with:
34-
browser: chrome
35-
headless: true
36-
start: npm run start.ci
37-
working-directory: ./packages/react/test-app
32+
- name: Install Dependencies
33+
run: npm install
34+
shell: bash
35+
working-directory: ./packages/react/test-app
36+
- name: Sync
37+
run: npm run sync
38+
shell: bash
39+
working-directory: ./packages/react/test-app
40+
- name: Build
41+
run: npm run build
42+
shell: bash
43+
working-directory: ./packages/react/test-app
44+
- name: Run E2E Tests
45+
run: npm run e2e
46+
shell: bash
47+
working-directory: ./packages/react/test-app

.github/workflows/actions/test-react-router-e2e/action.yml

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,19 @@ runs:
2929
name: ionic-react-router
3030
path: ./packages/react-router
3131
filename: ReactRouterBuild.zip
32-
- uses: cypress-io/github-action@v2
33-
with:
34-
browser: chrome
35-
headless: true
36-
start: npm run start.ci
37-
working-directory: ./packages/react-router/test-app
32+
- name: Install Dependencies
33+
run: npm install
34+
shell: bash
35+
working-directory: ./packages/react-router/test-app
36+
- name: Sync
37+
run: npm run sync
38+
shell: bash
39+
working-directory: ./packages/react-router/test-app
40+
- name: Build
41+
run: npm run build
42+
shell: bash
43+
working-directory: ./packages/react-router/test-app
44+
- name: Run E2E Tests
45+
run: npm run e2e
46+
shell: bash
47+
working-directory: ./packages/react-router/test-app

packages/react-router/test-app/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,10 @@
3636
},
3737
"scripts": {
3838
"start": "react-scripts start",
39-
"start.ci": "npm run sync && SKIP_PREFLIGHT_CHECK=true npm run build && serve -s build -l 3000",
4039
"build": "react-scripts build",
4140
"test": "cypress open",
4241
"cypress": "node_modules/.bin/cypress run --headless --browser chrome",
43-
"e2e": "npm run sync && concurrently \"SKIP_PREFLIGHT_CHECK=true react-scripts start\" \"wait-on http-get://localhost:3000 && npm run cypress\" --kill-others --success first",
42+
"e2e": "npm run sync && concurrently \"serve -s build -l 3000\" \"wait-on http-get://localhost:3000 && npm run cypress\" --kill-others --success first",
4443
"sync": "sh ./scripts/sync.sh"
4544
},
4645
"eslintConfig": {

packages/react/test-app/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,12 @@
4343
},
4444
"scripts": {
4545
"start": "react-scripts start",
46-
"start.ci": "npm run sync && SKIP_PREFLIGHT_CHECK=true npm run build && serve -s build -l 3000",
4746
"build": "react-scripts build",
4847
"test": "react-scripts test",
4948
"eject": "react-scripts eject",
5049
"sync": "sh ./scripts/sync.sh",
5150
"cypress": "cypress run --headless --browser chrome",
52-
"e2e": "concurrently \"SKIP_PREFLIGHT_CHECK=true npm run start -b\" \"wait-on http-get://localhost:3000 && npm run cypress\" --kill-others --success first"
51+
"e2e": "concurrently \"serve -s build -l 3000\" \"wait-on http-get://localhost:3000 && npm run cypress\" --kill-others --success first"
5352
},
5453
"eslintConfig": {
5554
"extends": [

0 commit comments

Comments
 (0)