Skip to content

docs(refresher): add component playgrounds #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 25, 2022
Merged

docs(refresher): add component playgrounds #2617

merged 13 commits into from
Oct 25, 2022

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Oct 19, 2022

Adds the following component playgrounds:

  • Basic Usage (a simple usage example with text content and a pull to refresh)
  • Advanced Usage (a more advanced usage example with a list and items appended to the beginning on refresh)
  • Pull Properties (a simple usage example with text content and a pull to refresh with custom pull properties)
  • Custom Refresher Content (a simple usage example with text content and a pull to refresh with a custom refresher content)
  • Usage with Virtual Scroll (a simple usage example with text content and a pull to refresh with a custom scroll target)

Preview Link: https://ionic-docs-git-fw-1273-ionic1.vercel.app/docs/api/refresher

@vercel
Copy link

vercel bot commented Oct 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ionic-docs ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 3:28PM (UTC)

@brandyscarney
Copy link
Member Author

I removed the unused imports, added a description for advanced usage and moved it to the bottom. Let me know if you see any issues!

Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you really nailed it with the code balance 👍 Just had a couple content-related comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants