Skip to content

docs(label): add label component playgrounds #2534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2022
Merged

docs(label): add label component playgrounds #2534

merged 2 commits into from
Sep 6, 2022

Conversation

brandyscarney
Copy link
Member

Adds component playgrounds for

  • Basic Usage
  • Item Labels
  • Input Labels
  • Theming
    • Colors

A playground for CSS Custom Properties was not added, documented why in Notion.

@vercel
Copy link

vercel bot commented Sep 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ionic-docs ✅ Ready (Inspect) Visit Preview Sep 6, 2022 at 4:16PM (UTC)

Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Playground component has a property called size that allows you to configure the rendered size to avoid scrolling (if desired). The default value is small.

Thoughts on increasing the rendered size of the "Item Labels" and "Input Labels" sections to possibly "medium" to avoid the vertical scroll bar?

@brandyscarney
Copy link
Member Author

@sean-perkins Ohhh thanks! I was wondering how to do that. I will try making it bigger!

@brandyscarney
Copy link
Member Author

Added a PR to the framework to specify the --color variable can only be used in an item: ionic-team/ionic-framework#25888

@brandyscarney brandyscarney merged commit c4c9287 into main Sep 6, 2022
@brandyscarney brandyscarney deleted the FW-1285 branch September 6, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants