Skip to content

docs(thumbnail): add component playgrounds and new svg #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Sep 1, 2022

  • Adds component playgrounds for thumbnail
  • Updates the thumbnail svg, image provided by Ben

localhost_3000_docs_api_thumbnail

@vercel
Copy link

vercel bot commented Sep 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ionic-docs ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 8:25PM (UTC)

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but either the alt text is not right or the image is not:

image

@brandyscarney
Copy link
Member Author

Code looks good, but either the alt text is not right or the image is not:

image

The image won't show up properly until it's deployed since it looks at ionicframework.com but it was updated here and verified locally: 2aae00c

@brandyscarney brandyscarney merged commit 9f35d78 into main Sep 1, 2022
@brandyscarney brandyscarney deleted the FW-1260 branch September 1, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants