Skip to content

docs(toast): add playgrounds #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 2, 2022
Merged

docs(toast): add playgrounds #2516

merged 12 commits into from
Sep 2, 2022

Conversation

averyjohnston
Copy link
Contributor

  • Removes the phone demo and Usage section
  • Moves TOC to the sidebar
  • Adds all playgrounds

I elected to do an Icons playground instead of the Complex Toast Structure one planned in the design doc, because in hindsight I felt the original was encouraging a design pattern that would be better suited for ion-alert.

@vercel
Copy link

vercel bot commented Aug 30, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ionic-docs ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 8:58PM (UTC)

liamdebeasi
liamdebeasi suggested changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Any chance we could spruce up the "Styling" section? Maybe we could use the toasts in Apple News as a reference? I'm more referring to the background/padding/box shadow/text color than the actual inner contents of the toast.

image

image

liamdebeasi
liamdebeasi approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Two small things, otherwise this is good on my end:

  1. Can we make the "Hello Styled World" text darker? It's a bit hard to read:
    image

  2. Can we change the "Styling" header to "Theming" based on the team discussion earlier today?

@averyjohnston averyjohnston merged commit bf5cd92 into main Sep 2, 2022
@averyjohnston averyjohnston deleted the FW-1258 branch September 2, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

@sean-perkins sean-perkins sean-perkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@averyjohnston @liamdebeasi @sean-perkins