Breaking ionic serve doesn't close the connection

[lordgreg]

Description:

Using ionic serve --port=8101 and then breaking it (CTRL+C) won't close the connection.

Steps to Reproduce:

1. install latest ionic locally and globally

The Ionic CLI has an update available (3.20.0 => 4.0.1)! Would you like to install it? Yes
> npm i -g ionic@latest
✔ Running command - done!

[OK] Updated Ionic CLI to 4.0.1! 🎉

Please re-run your command.

Note: You can downgrade to your old version by running: npm i -g ionic@3.20.0

2. run ionic serve --port=8101
3. wait for it to finish building.
4. CTRL+C
5. run ionic serve --port=8101
6. you will see he started using port 8102 since 8101 is occuped
7. check ionic processes: ps -ef | grep ionic
8. You now have two entries from serve.

My ionic info:

Ionic:

   ionic (Ionic CLI)  : 4.0.1
   Ionic Framework    : ionic-angular 3.9.2
   @ionic/app-scripts : 3.1.10

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : ios 4.5.4

System:

   Android SDK Tools : 26.1.1
   ios-deploy        : 1.9.2
   ios-sim           : 6.1.2
   NodeJS            : v10.0.0 (/usr/local/Cellar/node/10.0.0/bin/node)
   npm               : 6.2.0
   OS                : macOS High Sierra
   Xcode             : Xcode 9.4.1 Build version 9F2000

Environment:

   ANDROID_HOME : /Users/gregorpapez/Library/Android/sdk

[adailtonribeiro]

I'm having the same issue since the version '4.0.0-rc.11'. The version '4.0.0-rc.10' works fine for me.
...
4.0.0-rc.9 <-- It doesn't work
4.0.0-rc.10 <-- It works fine
4.0.0-rc.11 <-- It doesn't work
...
4.0.1 <-- It doesn't work

My ionic info:

Ionic:

ionic (Ionic CLI) : 4.0.1 (C:\Users\john\AppData\Roaming\npm\node_modules\ionic)
Ionic Framework : ionic-angular 3.9.2
@ionic/app-scripts : 3.1.11

Cordova:

cordova (Cordova CLI) : 8.0.0
Cordova Platforms : android 7.1.1

System:

Android SDK Tools : 26.1.1
NodeJS : v8.11.3 (C:\Program Files\nodejs\node.exe)
npm : 5.6.0
OS : Windows 10

Environment:

ANDROID_HOME : C:\Users\john\AppData\Local\Android\Sdk

[imhoffd]

I closed #3022 in favor of this one, because it already has better repro steps, information, etc.

This is the first time I've seen it happen on a non-Windows machine @lordgreg FWIW, I've never seen this on my machine, but several people have reported it.

@lordgreg @adailtonribeiro Could you paste the output of ps -ef | grep ionic (or similar command for windows)? Is it the Ionic CLI that is not shutting down or is it the ionic-app-scripts process?

@adailtonribeiro Interesting. I did change some things related to serve in rc.10 -> rc.11. @lordgreg Would you mind installing those and seeing if you see the same thing?

My ionic info:

Ionic:

   ionic (Ionic CLI)  : 4.0.1
   Ionic Framework    : ionic-angular 3.9.2
   @ionic/app-scripts : 3.1.8

Cordova:

   cordova (Cordova CLI) : 7.1.0
   Cordova Platforms     : android 6.2.3, ios 4.4.0

System:

   Android SDK Tools : 26.1.1
   NodeJS            : v8.11.3 (/Users/dan/.nvm/versions/node/v8.11.3/bin/node)
   npm               : 5.10.0
   OS                : macOS High Sierra
   Xcode             : Xcode 9.4.1 Build version 9F2000

Environment:

   ANDROID_HOME : /Users/dan/Library/Android/sdk

[adailtonribeiro]

@dwieeb I didn't find a similar command for windows but I think the ionic-app-scripts is shutting down properly because when I run npm run ionic:serve(ionic-app-scripts serve) it works

Using ionic CLI 4.0.1 and project type 'ionic-angular' (v3)

ionic serve <-- it's not shutting down properly
npm run ionic:serve <-- it's shutting down properly

Also ionic CLI 4.0.1 is not shutting down for project type 'angular' (v4)

My ionic info for project type 'angular':

Ionic:

   ionic (Ionic CLI)          : 4.0.1 (C:\Users\john\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.0
   @angular-devkit/core       : 0.7.1
   @angular-devkit/schematics : 0.7.1
   @angular/cli               : 6.1.1
   @ionic/ng-toolkit          : 1.0.0
   @ionic/schematics-angular  : 1.0.1

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : android 7.1.1

System:

   Android SDK Tools : 26.1.1
   NodeJS            : v8.11.3 (C:\Program Files\nodejs\node.exe)
   npm               : 5.6.0
   OS                : Windows 10

Environment:

   ANDROID_HOME : C:\Users\john\AppData\Local\Android\Sdk

[imhoffd]

@adailtonribeiro Thanks! Would you mind pasting the last bit of output of ionic serve --verbose? I am looking for output after this line:

  ionic:cli-framework:utils:process onBeforeExit handler: SIGINT received

[imhoffd]

@lordgreg If you send TERM signal to the process, is it killed?

Try kill <pid>

[lordgreg]

@dwieeb Thank you, here's the info you requested:

1. After killing the process,

▶ ps -ef | grep ionic
  501  4100     1   0 11:58am ??         0:02.00 ionic
  501 18761     1   0  8:17am ttys001    0:23.25 node /Users/XXXXXX/node_modules/.bin/ionic-app-scripts serve --address 0.0.0.0 --port 8101 --livereload-port 35729 --dev-logger-port 53703 --nobrowser
  501 18888     1   0  8:17am ttys001    0:03.37 node /Users/XXXXXX/node_modules/.bin/ionic-app-scripts serve --address 0.0.0.0 --port 8102 --livereload-port 35730 --dev-logger-port 53704 --nobrowser
  501 18890 18761   0  8:17am ttys001    0:00.86 /usr/local/Cellar/node/10.0.0/bin/node /Users/XXXXXX/node_modules/@ionic/app-scripts/dist/transpile-worker.js
  501 18965 18761   0  8:17am ttys001    0:02.58 /usr/local/Cellar/node/10.0.0/bin/node /Users/XXXXXX/node_modules/@ionic/app-scripts/dist/worker-process.js /usr/local/Cellar/node/10.0.0/bin/node /Users/XXXXXX/node_modules/.bin/ionic-app-scripts serve --address 0.0.0.0 --port 8101 --livereload-port 35729 --dev-logger-port 53703 --nobrowser -- --address 0.0.0.0 --port 8101 --livereload-port 35729 --dev-logger-port 53703 --nobrowser
  501 18969 12575   0  8:18am ttys001    0:00.00 grep --color=auto --exclude-dir=.bzr --exclude-dir=CVS --exclude-dir=.git --exclude-dir=.hg --exclude-dir=.svn ionic

And, as you can see, its about the ionic-app-scripts, not ionic.

One thing to take into the consideration, why am I taking another port? Because 8100 is taken from another process, unrelated to ionic.

Killing it, as you'we wrote, kills the process.

Projects/XXXX  master ✗                                                                                                                                                                                                           6m ⚑
▶ kill 18761

Projects/XXXX  master ✗                                                                                                                                                                                                           7m ⚑
▶ kill 18888

Projects/XXXX  master ✗                                                                                                                                                                                                           8m ⚑
▶ ps -ef | grep ionic
  501  4100     1   0 11:58am ??         0:02.00 ionic
  501 19337 12575   0  8:21am ttys001    0:00.00 grep --color=auto --exclude-dir=.bzr --exclude-dir=CVS --exclude-dir=.git --exclude-dir=.hg --exclude-dir=.svn ionic

[adailtonribeiro]

@dwieeb Running ionic serve --verbose using the ionic CLI 4.0.1 doesn't show anything after pressing (Ctrl + C)

However, if I use the ionic CLI 4.0.0-rc.10 after pressing (Ctrl + C) show those lines:

  ionic:cli-framework:utils:process onBeforeExit handler: SIGINT received +0ms
  ionic:cli-framework:utils:process onBeforeExit handler: running 2 queued functions +0ms
  ionic:cli-utils:lib:hooks Looking for ionic:serve:after npm script. +50s
  ionic:cli-framework:utils:process onBeforeExit handler: exiting (exit code 0) +16ms

[imhoffd]

@lordgreg Do you see "SIGINT received" in the verbose output?

I have found if the ionic process is killed forcefully (e.g. kill -9 <pid>), the ionic-app-scripts process continues running because the parent process doesn't have time to clean up its resources. If the CLI gets the chance to, it uses p.kill(), which is the same as kill <pid> (both TERM signal).

@lordgreg What is the output of stty -a?

@adailtonribeiro On Windows it's a bit different, I'm not exactly sure how NodeJS maps these signals. That's helpful, though. Do you see Environment closed. in the verbose output, at least?

Thank you both again for helping debug this. It is difficult to debug an issue I cannot reproduce on my own computer!

[janpio]

More reports:
https://forum.ionicframework.com/t/ionic-4-ionic-serve-port/136680
https://forum.ionicframework.com/t/ctrl-c-not-killing-the-process-node-server-ionic-cli-4-beta/136727

[lordgreg]

@dwieeb sorry for the late response,

After running

ionic serve -b --port=8101 --verbose

Here's the result when breaking the script (CTRL+C):

  ionic:discover:publisher Broadcasting 'ION_DP{"t":1533018194833,"id":"763534","nspace":"devapp","name":"Faketitle Ionic@8101","host":"my-external-host-here","ip":"192.168.56.1","port":8101,"commPort":53233,"path":"/"}' to 192.168.56.255 +0ms
  ionic:discover:publisher Broadcasting 'ION_DP{"t":1533018196835,"id":"763534","nspace":"devapp","name":"Faketitle Ionic@8101","host":"my-external-host-here","ip":"11.21.4.213","port":8101,"commPort":53233,"path":"/"}' to 11.21.7.255 +2s
  ionic:discover:publisher Broadcasting 'ION_DP{"t":1533018196835,"id":"763534","nspace":"devapp","name":"Faketitle Ionic@8101","host":"my-external-host-here","ip":"192.168.56.1","port":8101,"commPort":53233,"path":"/"}' to 192.168.56.255 +1ms
  ionic:discover:publisher Broadcasting 'ION_DP{"t":1533018198837,"id":"763534","nspace":"devapp","name":"Faketitle Ionic@8101","host":"my-external-host-here","ip":"11.21.4.213","port":8101,"commPort":53233,"path":"/"}' to 11.21.7.255 +2s
  ionic:discover:publisher Broadcasting 'ION_DP{"t":1533018198837,"id":"763534","nspace":"devapp","name":"Faketitle Ionic@8101","host":"my-external-host-here","ip":"192.168.56.1","port":8101,"commPort":53233,"path":"/"}' to 192.168.56.255 +0ms

  ionic:cli-framework:utils:process onBeforeExit handler: SIGINT received +0ms
  ionic:cli-framework:utils:process onBeforeExit handler: running 2 queued functions +0ms
  ionic:cli-utils:lib:hooks Looking for ionic:serve:after npm script. +52s
  ionic:cli-framework:utils:process onBeforeExit handler: exiting (exit code 0) +2ms

The ps output is the same, killable with kill pid command.