Source maps are not disabled in prod build

[ryaa]

Note: for support questions, please use one of these channels:

https://forum.ionicframework.com/
http://ionicworldwide.herokuapp.com/

Short description of the problem:

Issuing ionic build android --release --prod creates production apk which still includes source maps. Those must be disabled in the production build

What behavior are you expecting?

Source maps disabled in production build.

Steps to reproduce:

1. make sure that in package.json
   "ionic_generate_source_map": true
2. run ionic build android --release --prod
   Production APK file created still contains source map files

insert any relevant code between the above and below backticks

Which @ionic/app-scripts version are you using?
1.3.7

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

[danbucholtz]

Hi @ryaa,

Since you have the ionic_generate_source_map flag set to true, it makes sense that the source map is preserved. This is by design.

Thanks,
Dan

[ryaa]

Setting this to false gives an error. The same as here #934

So I don't see any way to disable source maps for the PROD build. That's the problem

[ryaa]

Dan, here you state that source maps are disabled for prod build by default - see comment made on Jan 11 #289 (comment)

[danbucholtz]

Not using eval source maps will fix it. eval source maps for prod would be very bad.

Thanks,
Dan

[ryaa]

Dan, are you saying that if i use anything besides eval (for example "ionic_source_map_type": "#inline-source-map" or "source-map") and "ionic_generate_source_map": is true the ionic-app-scripts will disable the source maps by default in PROD build?

The problem is that it is not possible to create PROD build without source maps. The "ionic_generate_source_map": false configuration does not work (gives an error) and if it is true it includes source maps into the production build.

[danbucholtz]

@ryaa,

Remove ionic_generate_source_map from package.json unless you want a source map.

Remove ionic_source_map_type as well.

You should be good to go.

Thanks,
Dan

[aelsharif]

using this will fix it
ionic-app-scripts build --prod --generateSourceMap false

[ryaa]

Thank you very much @aelsharif
This did the trick!

Note that "ionic_source_map_type" must be "source-map"
If this is "ionic_source_map_type": "#inline-source-map" it still triggers the error even with --generateSourceMap false

[cocowalla]

@ryaa if ionic_source_map_type is source-map, then I don't get any source maps when building debug builds!

[ryaa]

@cocowalla what is the ionic-app-scripts version? and what is the value for "ionic_generate_source_map"? if it is false and you use the latest ionic-app-scripts version that this is expected behaviour, I think

[cocowalla]

@ryaa app-scripts are at 2.1.4, but this problem has persisted for many previous versions.

ionic_generate_source_map is not set in package.json. if I set it to true and ionic_source_map_type is source-map, I still don't get any source maps - I only get them using #inline-source-map - but then of course I can't built with --prod --release!

[ryaa]

@cocowalla strange. I use 2.1.3 and can generate source maps with ionic_generate_source_map true and ionic_source_map_type source-map settings...