fix(): proper exception handling in some edge cases users were encountering

Author: danbucholtz

src/lint.ts

@@ -22,19 +22,16 @@ export function lint(context?: BuildContext, configFile?: string) {
 
 
 export function lintWorker(context: BuildContext, configFile: string) {
+  const logger = new Logger('lint');
   return getLintConfig(context, configFile).then(configFile => {
     // there's a valid tslint config, let's continue
-    const logger = new Logger('lint');
-
-    return lintApp(context, configFile)
-      .then(() => {
-        // always finish and resolve
-        logger.finish();
-
-      }).catch(() => {
-        // always finish and resolve
-        logger.finish();
-      });
+    return lintApp(context, configFile);
+  }).then(() => {
+    // always finish and resolve
+    logger.finish();
+  }).catch(() => {
+    // always finish and resolve
+    logger.finish();
   });
 }
 
@@ -55,15 +52,11 @@ export function lintUpdate(event: string, filePath: string, context: BuildContex
 
 export function lintUpdateWorker(context: BuildContext, workerConfig: LintWorkerConfig) {
   return getLintConfig(context, workerConfig.configFile).then(configFile => {
-      // there's a valid tslint config, let's continue (but be quiet about it!)
-      const program = createProgram(configFile, context.srcDir);
-      return lintFile(context, program, workerConfig.filePath);
-
-    }, () => {
-      // rejected, but let's ignore
-    }).catch(() => {
-      // error, but whateves
-    });
+    // there's a valid tslint config, let's continue (but be quiet about it!)
+    const program = createProgram(configFile, context.srcDir);
+    return lintFile(context, program, workerConfig.filePath);
+  }).catch(() => {
+  });
 }
 
 

src/sass.ts

@@ -89,7 +89,7 @@ export function sassWorker(context: BuildContext, configFile: string) {
         reject(reason);
       })
       .catch(err => {
-        throw new BuildError(err);
+        reject(new BuildError(err));
       });
   });
 }

src/worker-client.ts

@@ -29,7 +29,7 @@ export function runWorker(taskModule: string, taskWorker: string, context: Build
 
     worker.on('message', (msg: WorkerMessage) => {
       if (msg.error) {
-        throw new BuildError(msg.error);
+        reject(new BuildError(msg.error));
       } else if (msg.reject) {
         reject(new BuildError(msg.reject));
       } else {