Revert "build: use %PYTHON% instead of python" #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain in the commit log why you are reverting it? Apart from that LGTM. |
This reverts commit 91943a9. Old commit cherry-picked in but found to cause problems with .msi creation on Windows. Original change is mostly pointless because V8 hard-wires `python` anyway. PR-URL: nodejs#1475 Reviewed-By: Ben Noordhuis <[email protected]>
|
landed @ 53ed89d thanks @bnoordhuis |
|
I guess it should be merged into |
|
@targos 1.8.1 will still be merged into master. (Future 1.x patches will not be.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 91943a9.
this is in #1460 but I wanted to get it in ASAP so I can try the release builds again
anyone awake that can review? @jbergstroem? @bnoordhuis?