Skip to content

Conversation

yorkie
Copy link
Contributor

@yorkie yorkie commented Mar 8, 2015

Caught this one in reading the util doc, checked the doc of nodej and iojs:

But the github markdown worked at https://github.com/iojs/io.js/blob/v1.x/doc/api/util.markdown#utilformatformat-

Well, now I fixed the confusion bug on on this line, but btw, I think we should keep using the markdown parser same to github markdown, so that we needn't another review on website. I'm interested in this proposal if someone could give me the guiding link on how the website are built and working, Thank you :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is over 80 characters now. Could you just remove the indentation from the original text?

@yorkie
Copy link
Contributor Author

yorkie commented Mar 8, 2015

Fixed @cjihrig Thank you

@brendanashworth
Copy link
Contributor

looks good to me

brendanashworth pushed a commit that referenced this pull request Mar 8, 2015
@brendanashworth
Copy link
Contributor

Thanks @yorkie, this has been merged in f8c893d.

Regarding the parser, the Makefile rule is here which seems to call this guy. Good luck 👍 if you want some more thoughts about it beforehand, you could open up an issue.

@rvagg rvagg mentioned this pull request Mar 8, 2015
@yorkie yorkie deleted the fix/doc-util branch March 9, 2015 03:22
@yorkie
Copy link
Contributor Author

yorkie commented Mar 9, 2015

Thanks for your link, @brendanashworth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants