Skip to content

Properly fix build breaks from #193 #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2019
Merged

Properly fix build breaks from #193 #204

merged 3 commits into from
Jun 7, 2019

Conversation

AlCalzone
Copy link
Collaborator

PR Checklist:

  • Provide a meaningful description to this PR or mention which issues this fixes.
  • Add tests for your change. This includes negative tests (i.e. inputs that need to fail) as well as baseline tests (i.e. how should the directory structure look like?).
  • Run the test suite with npm test
  • If there are baseline changes, review them and make a separate commit for them with the comment "accept baselines" if they are desired changes
  • Ensure the project builds with npm run build
  • If you added a required option, also add it to the template creation (travis/create_templates.ts)
  • Add your changes to CHANGELOG.md (referencing this PR or the issue you fixed)

Description:
The original fix (ec3d8a3) broke the creator instead

@AlCalzone AlCalzone self-assigned this Jun 7, 2019
@AlCalzone AlCalzone merged commit b2e16cc into master Jun 7, 2019
@AlCalzone AlCalzone deleted the emergency-fix branch June 7, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant