Skip to content

feat: new workflow library #7710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Mar 6, 2025
Merged

Conversation

maryhipp
Copy link
Collaborator

@maryhipp maryhipp commented Feb 28, 2025

Summary

Add new workflow library UI:

  • Library is now in a large modal with cards instead of slim list (potential for list view as a future enhancement).
  • Workflows divvied up into last 5 opened (Recent), user workflows (Your Workflows), and default workflows (Browse Workflows).
  • Default workflows are categorized by predefined categories and tags. The categories and tags are tentative.

Internal changes

  • Add a generated tags column to workflow library table, which pulls the tags out of the workflow JSON.
  • Add tag searching to workflow records service & endpoint.
  • Add a counts method to workflow records service & endpoint, which can be used to get the number of workflows in the any of the provided categories and with any of the provided tags. This is used to prevent perf issues with loading and deserializing literally all workflows just to count them.
  • Previously, the workflow records service bumped the opened at timestamp when the get method was called. That does not really work - we call get all the time. It doesn't map to the user opening the workflow. There is a new method and endpoint to set the timestamp to the current time. The frontend hits this endpoint when the user loads a workflow to view or edit.
  • Bumped RTK to latest to get infinite query support, used in the new library.

TODO:

  • Iterate on styling and layout.
  • Fix/add RTK query cache invalidation for all workflow library endpoints. For example, if you sort workflows by opened at, then open a workflow, the library does not re-sort itself. We need to invalidate the query cache for the library so it re-fetches the list with the updated timestamps.
  • Internal code cleanup, especially the react components.

Related Issues / Discussions

n/a

QA Instructions

This will be put into an alpha release for user testing.

Merge Plan

I will do an alpha release.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added api python PRs that change python files services PRs that change app services frontend PRs that change frontend files labels Feb 28, 2025
@psychedelicious psychedelicious force-pushed the maryhipp/another-new-workflow-library branch from 00532a3 to 2beba09 Compare March 4, 2025 04:59
@github-actions github-actions bot added the python-tests PRs that change python tests label Mar 4, 2025
@psychedelicious psychedelicious changed the base branch from main to psyche/feat/app/stable-default-workflows March 4, 2025 05:00
@github-actions github-actions bot added the frontend-deps PRs that change frontend dependencies label Mar 5, 2025
@psychedelicious psychedelicious force-pushed the psyche/feat/app/stable-default-workflows branch from f20ab50 to 43aae93 Compare March 5, 2025 23:43
Base automatically changed from psyche/feat/app/stable-default-workflows to main March 5, 2025 23:57
@psychedelicious psychedelicious force-pushed the maryhipp/another-new-workflow-library branch 2 times, most recently from 9f96378 to 6c9661a Compare March 6, 2025 04:13
@psychedelicious psychedelicious changed the title Maryhipp/another new workflow library feat: new workflow library Mar 6, 2025
@psychedelicious psychedelicious marked this pull request as ready for review March 6, 2025 05:53
@psychedelicious psychedelicious force-pushed the maryhipp/another-new-workflow-library branch from 1fee3d2 to dccce9d Compare March 6, 2025 21:16
@psychedelicious psychedelicious merged commit 58959a1 into main Mar 6, 2025
15 checks passed
@psychedelicious psychedelicious deleted the maryhipp/another-new-workflow-library branch March 6, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies python PRs that change python files python-tests PRs that change python tests services PRs that change app services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants