tests(mm): another attempt to fix windows ci test issue

Author: psychedelicious

invokeai/app/services/model_install/model_install_default.py

@@ -8,7 +8,7 @@
 from copy import deepcopy
 from pathlib import Path
 from queue import Empty, Queue
-from shutil import move, rmtree
+from shutil import move
 from tempfile import mkdtemp
 from typing import TYPE_CHECKING, Any, Dict, List, Optional, Tuple, Type, Union
 
@@ -56,7 +56,7 @@
 from invokeai.backend.util import InvokeAILogger
 from invokeai.backend.util.catch_sigint import catch_sigint
 from invokeai.backend.util.devices import TorchDevice
-from invokeai.backend.util.util import slugify
+from invokeai.backend.util.util import safe_rmtree, slugify
 
 if TYPE_CHECKING:
     from invokeai.app.services.events.events_base import EventServiceBase
@@ -376,12 +376,12 @@ def unconditionally_delete(self, key: str) -> None:  # noqa D102
             # Sanity check - file models should be in their own directory under the models dir. The parent of the
             # file should be the model's directory, not the Invoke models dir!
             assert model_path.parent != self.app_config.models_path
-            rmtree(model_path.parent)
+            safe_rmtree(model_path.parent)
         elif model_path.is_dir():
             # Sanity check - folder models should be in their own directory under the models dir. The path should
             # not be the Invoke models dir itself!
             assert model_path != self.app_config.models_path
-            rmtree(model_path)
+            safe_rmtree(model_path)
         self.unregister(key)
 
     @classmethod
@@ -511,7 +511,7 @@ def _install_next_item(self) -> None:
             finally:
                 # if this is an install of a remote file, then clean up the temporary directory
                 if job._install_tmpdir is not None:
-                    rmtree(job._install_tmpdir)
+                    safe_rmtree(job._install_tmpdir)
                 self._install_completed_event.set()
                 self._install_queue.task_done()
         self._logger.info(f"Installer thread {threading.get_ident()} exiting")
@@ -556,7 +556,7 @@ def _remove_dangling_install_dirs(self) -> None:
         path = self._app_config.models_path
         for tmpdir in path.glob(f"{TMPDIR_PREFIX}*"):
             self._logger.info(f"Removing dangling temporary directory {tmpdir}")
-            rmtree(tmpdir)
+            safe_rmtree(tmpdir)
 
     def _scan_for_missing_models(self) -> list[AnyModelConfig]:
         """Scan the models directory for missing models and return a list of them."""

invokeai/backend/util/util.py

@@ -2,6 +2,8 @@
 import io
 import os
 import re
+import shutil
+import stat
 import unicodedata
 from pathlib import Path
 
@@ -74,3 +76,19 @@ def __enter__(self):
 
     def __exit__(self, *args):
         os.chdir(self.original)
+
+
+def remove_readonly(func, path, _):
+    """Clear the readonly bit and reattempt the removal. Used with shutil.rmtree."""
+    os.chmod(path, stat.S_IWRITE)
+    func(path)
+
+
+def safe_rmtree(path: Path):
+    """Recursively delete a directory tree, even if it contains read-only files.
+
+    Useful for cleaning up temporary directories on Windows.
+
+    See: https://docs.python.org/3/library/shutil.html#rmtree-example
+    """
+    shutil.rmtree(path, onexc=remove_readonly)