Skip to content

Commit 6006616

Browse files
committed
fix(ios): use 'note' for info messages in Xcode scripts
info has no semantic meaning in Xcode build scripts, so they were not printed. But note does (as does error and warning, which were used correctly)
1 parent 0fcc983 commit 6006616

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

packages/app/ios_config.sh

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ _PLIST_ENTRY_TYPES=()
4646
_PLIST_ENTRY_VALUES=()
4747

4848
function setPlistValue {
49-
echo "info: setting plist entry '$1' of type '$2' in file '$4'"
50-
${_PLIST_BUDDY} -c "Add :$1 $2 '$3'" $4 || echo "info: '$1' already exists"
49+
echo "note: setting plist entry '$1' of type '$2' in file '$4'"
50+
${_PLIST_BUDDY} -c "Add :$1 $2 '$3'" $4 || echo "note: '$1' already exists"
5151
}
5252

5353
function getFirebaseJsonKeyValue () {
@@ -67,8 +67,8 @@ function jsonBoolToYesNo () {
6767
fi
6868
}
6969

70-
echo "info: -> RNFB build script started"
71-
echo "info: 1) Locating ${_JSON_FILE_NAME} file:"
70+
echo "note: -> RNFB build script started"
71+
echo "note: 1) Locating ${_JSON_FILE_NAME} file:"
7272

7373
if [[ -z ${_CURRENT_SEARCH_DIR} ]]; then
7474
_CURRENT_SEARCH_DIR=$(pwd)
@@ -77,10 +77,10 @@ fi;
7777
while true; do
7878
_CURRENT_SEARCH_DIR=$(dirname "$_CURRENT_SEARCH_DIR")
7979
if [[ "$_CURRENT_SEARCH_DIR" == "/" ]] || [[ ${_CURRENT_LOOKUPS} -gt ${_MAX_LOOKUPS} ]]; then break; fi;
80-
echo "info: ($_CURRENT_LOOKUPS of $_MAX_LOOKUPS) Searching in '$_CURRENT_SEARCH_DIR' for a ${_JSON_FILE_NAME} file."
80+
echo "note: ($_CURRENT_LOOKUPS of $_MAX_LOOKUPS) Searching in '$_CURRENT_SEARCH_DIR' for a ${_JSON_FILE_NAME} file."
8181
_SEARCH_RESULT=$(find "$_CURRENT_SEARCH_DIR" -maxdepth 2 -name ${_JSON_FILE_NAME} -print | /usr/bin/head -n 1)
8282
if [[ ${_SEARCH_RESULT} ]]; then
83-
echo "info: ${_JSON_FILE_NAME} found at $_SEARCH_RESULT"
83+
echo "note: ${_JSON_FILE_NAME} found at $_SEARCH_RESULT"
8484
break;
8585
fi;
8686
_CURRENT_LOOKUPS=$((_CURRENT_LOOKUPS+1))
@@ -94,7 +94,7 @@ if [[ ${_SEARCH_RESULT} ]]; then
9494
fi
9595

9696
if [[ ${_RN_ROOT_EXISTS} ]]; then
97-
if ! python3 --version >/dev/null 2>&1; then echo "python3 not found, firebase.json file processing error." && exit 1; fi
97+
if ! python3 --version >/dev/null 2>&1; then echo "error: python3 not found, firebase.json file processing error." && exit 1; fi
9898
_JSON_OUTPUT_BASE64=$(python3 -c 'import json,sys,base64;print(base64.b64encode(bytes(json.dumps(json.loads(open('"'${_SEARCH_RESULT}'"', '"'rb'"').read())['${_JSON_ROOT}']), '"'utf-8'"')).decode())' || echo "e30=")
9999
fi
100100

@@ -238,7 +238,7 @@ else
238238
echo "warning: A firebase.json file was not found, whilst this file is optional it is recommended to include it to configure firebase services in React Native Firebase."
239239
fi;
240240

241-
echo "info: 2) Injecting Info.plist entries: "
241+
echo "note: 2) Injecting Info.plist entries: "
242242

243243
# Log out the keys we're adding
244244
for i in "${!_PLIST_ENTRY_KEYS[@]}"; do
@@ -266,4 +266,4 @@ for plist in "${_TARGET_PLIST}" "${_DSYM_PLIST}" ; do
266266
fi
267267
done
268268

269-
echo "info: <- RNFB build script finished"
269+
echo "note: <- RNFB build script finished"

0 commit comments

Comments
 (0)