Skip to content

feat(GH-204): added LOWER predicate for case insensitive match #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2019

Conversation

igdianov
Copy link
Collaborator

This PR adds LOWER predicate for case insensitive match, i.e. given query

query {
  Books(where: {title: {LOWER: "WAR AND PEACE"}}) {
    select {
      id
      title
    }
  }
}

the expected result is

{
  "data": {
    "Books": {
      "select": [
        {
          "id": 2,
          "title": "War and Peace"
        }
      ]
    }
  }
}

Fixes #204

@igdianov igdianov self-assigned this Oct 12, 2019
@codecov
Copy link

codecov bot commented Oct 13, 2019

Codecov Report

Merging #206 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #206      +/-   ##
============================================
+ Coverage     73.64%   73.76%   +0.11%     
- Complexity      876      878       +2     
============================================
  Files            50       50              
  Lines          3711     3720       +9     
  Branches        626      627       +1     
============================================
+ Hits           2733     2744      +11     
+ Misses          699      698       -1     
+ Partials        279      278       -1
Impacted Files Coverage Δ Complexity Δ
...graphql/jpa/query/schema/impl/PredicateFilter.java 100% <100%> (ø) 5 <0> (ø) ⬇️
...hql/jpa/query/schema/impl/JpaPredicateBuilder.java 58.87% <100%> (+0.27%) 110 <0> (+1) ⬆️
...jpa/query/schema/impl/GraphQLJpaSchemaBuilder.java 91.27% <100%> (+0.07%) 118 <0> (ø) ⬇️
.../graphql/jpa/query/introspection/Constructors.java 82% <0%> (+4%) 15% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f1e36c...4eadb5b. Read the comment docs.

@igdianov igdianov merged commit 6ff6992 into master Oct 13, 2019
@igdianov igdianov deleted the igdianov-feat-case-insensitive-match branch October 13, 2019 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to force lower / upper on string equality check?
1 participant