-
Notifications
You must be signed in to change notification settings - Fork 55
feat: add support for variable where criteria expressions #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for variable where criteria expressions #162
Conversation
@anotender Here is the first crack of the support passing where criteria expressions via variables. Feel free to try adding any test cases for your requirements... |
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
============================================
+ Coverage 68.12% 68.65% +0.52%
- Complexity 502 510 +8
============================================
Files 33 33
Lines 2576 2597 +21
Branches 431 431
============================================
+ Hits 1755 1783 +28
+ Misses 644 643 -1
+ Partials 177 171 -6
Continue to review full report at Codecov.
|
.../main/java/com/introproventures/graphql/jpa/query/schema/impl/QraphQLJpaBaseDataFetcher.java
Outdated
Show resolved
Hide resolved
@igdianov as for me, the changes look ok at the moment. Do you want to add something more? |
@anotender Thanks! Everything looks good. I will merge and release this on the weekend. I am using STS 4.0 with custom formatter. I don't know how to export to IDEA. I will try to find a matching IDEA configuration. |
This PR adds support for variable where criteria expressions, i.e. given
with variables payload:
the expected result will be:
Fixes #126