Skip to content

feat: add NE predicate for custom attributes criteria expressions #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2019

Conversation

igdianov
Copy link
Collaborator

@igdianov igdianov commented May 7, 2019

This PR adds support for NE predicates on custom attributes criteria expressions, i.e.

query {
  TaskVariables(where: { 
    value: {NE: null} 
  }) {
    select {
      name
      value
    }
  }
}

@igdianov igdianov self-assigned this May 7, 2019
@igdianov igdianov changed the title feat: add NE predicate for custom converter attributes criteria feat: add NE predicate for custom attributes criteria expressions May 7, 2019
@igdianov igdianov merged commit 4862ad0 into master May 7, 2019
@igdianov igdianov deleted the igdianov-ne-custom-attribute branch May 7, 2019 04:18
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #140 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #140      +/-   ##
============================================
+ Coverage     68.23%   68.28%   +0.05%     
- Complexity      437      439       +2     
============================================
  Files            33       33              
  Lines          2238     2242       +4     
  Branches        331      333       +2     
============================================
+ Hits           1527     1531       +4     
  Misses          576      576              
  Partials        135      135
Impacted Files Coverage Δ Complexity Δ
...hql/jpa/query/schema/impl/JpaPredicateBuilder.java 52.98% <100%> (+0.76%) 58 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2ddd4d...de53c8c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant