Skip to content

Let's pass and apply distinct in query results if enabled #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2019

Conversation

igdianov
Copy link
Collaborator

Fixes #118

@igdianov igdianov self-assigned this Apr 28, 2019
@igdianov igdianov added the bug label Apr 28, 2019
@igdianov igdianov changed the title fix: let's pass distinct if enabled Let's pass and apply distinct in query results if enabled Apr 28, 2019
@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #124 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
+ Coverage     67.03%   67.05%   +0.01%     
- Complexity      401      402       +1     
============================================
  Files            33       33              
  Lines          2063     2064       +1     
  Branches        305      306       +1     
============================================
+ Hits           1383     1384       +1     
  Misses          555      555              
  Partials        125      125
Impacted Files Coverage Δ Complexity Δ
.../query/schema/impl/GraphQLJpaQueryDataFetcher.java 93.33% <100%> (+0.07%) 22 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ad369...6376ce1. Read the comment docs.

@igdianov igdianov merged commit dcb037b into master Apr 28, 2019
@igdianov igdianov deleted the igdianov-116-fix-distinct branch April 28, 2019 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinct SQL does not work properly
1 participant