Skip to content

Conversation

@panley01
Copy link
Contributor

Also adds Application flag checks to the client code, checking priv. intents against Application flags to raise exceptions on unpermitted intents before initiating a connection with Discord.

Copy link
Contributor

@i0bs i0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have pleased me.

@FayeDel FayeDel changed the base branch from stable to unstable January 29, 2022 04:20
@FayeDel FayeDel self-requested a review January 29, 2022 04:25
@panley01
Copy link
Contributor Author

Amended code to account for _intent as opposed to intent & priv intent flags for unverified apps (_LIMITED suffix). Also moved intent checks before command checks for that sweet nanosecond optimizaton on knowing you fucked up

Co-authored-by: Damego <[email protected]>
@i0bs
Copy link
Contributor

i0bs commented Jan 29, 2022

Covering over Delta's review part, but the changes look proper and I haven't hit any issues in testing. LGTM. Thank you for contributing, gamer. 🤓

@i0bs i0bs merged commit 03e1093 into interactions-py:unstable Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants