Skip to content

Conversation

@Catalyst4222
Copy link
Contributor

About

This pr adds in the ability to limit cache
Draft until proper default limits are set

Checklist

  • The pre-commit code linter has been run over all edited files to ensure the code is linted.
  • I've ensured the change(s) work on 3.8.6 and higher.

I've made this pull request: (check all that apply)

  • For the documentation
  • To add a new feature
  • As a general enhancement
  • As a refactor of the library/the library's code
  • To fix an existing bug
  • To resolve [REQUEST] Limiting cache #482

This is:

  • A breaking change

@Catalyst4222 Catalyst4222 marked this pull request as draft October 20, 2022 03:22
@Catalyst4222 Catalyst4222 marked this pull request as ready for review October 28, 2022 03:24
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good, just one small thing

@Catalyst4222 Catalyst4222 requested a review from Toricane October 28, 2022 03:54
@Catalyst4222 Catalyst4222 requested a review from Toricane November 2, 2022 01:52
Copy link
Contributor

@Toricane Toricane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmmm LGTM

Copy link
Contributor

@EepyElvyra EepyElvyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm ig

@EepyElvyra
Copy link
Contributor

Merge conflicts :D

@Catalyst4222
Copy link
Contributor Author

F30EE5FE-A567-496C-A1FD-1E4888B2C09E

@Catalyst4222 Catalyst4222 merged commit 050b2d3 into interactions-py:unstable Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants