Skip to content

fix: typehint channels correctly in event classes #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix: typehint channels correctly in event classes #1538

merged 1 commit into from
Aug 25, 2023

Conversation

mAxYoLo01
Copy link
Contributor

…in Events classes

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

This PR is to avoid these types of warnings from IDEs:
image
(extracted from support server)

Changes

Related Issues

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@AstreaTSS AstreaTSS changed the title fix!: Channels typehinted to TYPE_ALL_CHANNEL instead of BaseChannel … fix: Channels typehinted to TYPE_ALL_CHANNEL instead of BaseChannel … Aug 25, 2023
@AstreaTSS AstreaTSS changed the title fix: Channels typehinted to TYPE_ALL_CHANNEL instead of BaseChannel … fix: typehint channels correctly in event classes Aug 25, 2023
AstreaTSS
AstreaTSS approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@AstreaTSS AstreaTSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's some funky pre-commit.

@AstreaTSS AstreaTSS merged commit 164e01f into interactions-py:unstable Aug 25, 2023
@mAxYoLo01
Copy link
Contributor Author

That's some funky pre-commit.

I thought that the pre-commit had an isort in it, does it not? Everytime I PR it changes all imports places lol

@mAxYoLo01 mAxYoLo01 deleted the typehint-channels branch August 29, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silasary silasary silasary approved these changes

@AstreaTSS AstreaTSS AstreaTSS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mAxYoLo01 @silasary @AstreaTSS