This repository was archived by the owner on Aug 5, 2022. It is now read-only.
[ocf/promises] Fixed OCF crash because of bug from promise patch #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 7, 2017 09:13
- Fixed OCF on linux by updating iotivity-constrained (client + server compiled in previously did not work) Signed-off-by: James Prestwood <[email protected]>
Signed-off-by: James Prestwood <[email protected]>
grgustaf
reviewed
Mar 7, 2017
src/zjs_test_promise.c
Outdated
| { | ||
| if (handle) { | ||
| dummy_handle_t* h = (dummy_handle_t*)handle; | ||
| if (h->value != 42) { |
There was a problem hiding this comment.
Thanks for the test. But move this constant definition up to a #define or something to make it more clear.
Signed-off-by: James Prestwood <[email protected]>
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(client + server compiled in previously did not work)
Signed-off-by: James Prestwood [email protected]