This repository was archived by the owner on Aug 5, 2022. It is now read-only.
[sensor] Fix sensor to pass unit test #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sensor tests are broken because because the callstack is corrupted when sending IPM messages, and this patch rewrite the start sensor logic to have a callback that's called from the mainloop instead for a smaller call stack. Also fixed an issue where stop fails on AmbientLightSensor Signed-off-by: Jimmy Huang <[email protected]>
grgustaf
reviewed
Mar 6, 2017
src/zjs_sensor.c
Outdated
| @@ -450,7 +496,7 @@ static jerry_value_t zjs_sensor_create(const jerry_value_t function_obj, | |||
| enum sensor_channel channel) | |||
| { | |||
| double frequency = DEFAULT_SAMPLING_FREQUENCY; | |||
| uint32_t pin; | |||
| uint32_t pin = -1; | |||
There was a problem hiding this comment.
Let's not assign negative numbers to unsigned ints, even if it works. :)
I guess use 0xffffffff?
Signed-off-by: Jimmy Huang <[email protected]>
|
@grgustaf updated patch |
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sensor tests are broken because because the callstack is corrupted
when sending IPM messages, and this patch rewrite the start sensor
logic to have a callback that's called from the mainloop instead
for a smaller call stack. Also fixed an issue where stop fails
on AmbientLightSensor
Signed-off-by: Jimmy Huang [email protected]