Fix smoothquant minmax observer init #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
yintong-lu
approved these changes
Nov 27, 2023
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
ipex 2.1.0 requests observer object, but ipex 2.1.1 requests observer class.
ipex 2.1.0 code
https://github.com/intel-innersource/frameworks.ai.pytorch.ipex-cpu/blob/v2.1.0%2Bcpu-rc4/intel_extension_for_pytorch/quantization/_smooth_quant.py#L85
ipex 2.1.1 code
https://github.com/intel-innersource/frameworks.ai.pytorch.ipex-cpu/blob/v2.1.100%2Bcpu-rc0/intel_extension_for_pytorch/quantization/_smooth_quant.py#L75
Description
detail description
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed