V2021.8 #53
Merged
V2021.8 #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix warnings -Wstrict-prototypes fix warnings due to incorrect declaration classes fix warnings due to c++11/17 standarts fix compiler warnings in GPU case fix build warnings with openMPI fix cleanning IMB without GPU
| @@ -342,7 +342,11 @@ Input variables: | |||
| break; | |||
|
|
|||
| case SAMPLE_FAILED_INT_OVERFLOW: | |||
| sprintf(aux_string + offset, " int-overflow.; The production rank*size caused int overflow for given sample"); | |||
| #ifdef MPI1 | |||
| sprintf(aux_string + offset, " int-overflow; The production rank*size caused int overflow for given sample; use flag \"-data_type double\""); | |||
There was a problem hiding this comment.
seems like there is aux_string overflow in overflow message. aux_string is 104 bytes, but the string " int-overflow; The production rank*size caused int overflow for given sample; use flag "-data_type double"" is 106 bytes
There was a problem hiding this comment.
@Sergei-Lebedev did you face with problem ? Please give me scenario if "yes".
There was a problem hiding this comment.
just gcc compilation fails with two errors
../src_c/IMB_chk_diff.c:1065:13: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
1065 | if (ranks[i + 1] == rank && pos2 - pos1 + 1 == (lengths[i] + (lengths[i + 1])))
| ^~
../src_c/IMB_chk_diff.c:1066:41: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
1066 | c_info->reccnt[rank]++; i++;
| ^
/tmp/ompi/install/bin/mpicc -g -O0 -Wall -Werror -DCHECK=1 -Ihelpers -I../src_c -DMPI1 -I. -DMPI1 -c -o MPI1/CPU/IMB_warm_up.o ../src_c/IMB_warm_up.c
/tmp/ompi/install/bin/mpicxx -DCHECK=1 -Ihelpers -I../src_c -DMPI1 -I. -g -O0 -Wall -Wextra -Werror -DMPI1 -c -o MPI1/CPU/MPI1_suite.o MPI1/MPI1_suite.cpp
/tmp/ompi/install/bin/mpicxx -DCHECK=1 -Ihelpers -I../src_c -DMPI1 -I. -g -O0 -Wall -Wextra -Werror -DMPI1 -c -o MPI1/CPU/MPI1_benchmark.o MPI1/MPI1_benchmark.cpp
../src_c/IMB_output.c: In function ‘IMB_display_times’:
../src_c/IMB_output.c:346:152: error: ‘ int-overflow; The productio...’ directive writing 106 bytes into a region of size 104 [-Werror=format-overflow=]
346 | sprintf(aux_string + offset, " int-overflow; The production rank*size caused int overflow for given sample; use flag \"-data_type double\"");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
../src_c/IMB_output.c:346:17: note: ‘sprintf’ output 107 bytes into a destination of size 104
346 | sprintf(aux_string + offset, " int-overflow; The production rank*size caused int overflow for given sample; use flag \"-data_type double\"");
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
There was a problem hiding this comment.
@Sergei-Lebedev please try to use branch from #54 and let me know is it works for you or not.
There was a problem hiding this comment.
@JuliaRS, thanks for the quick fix, it helped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.