[SYCL] Enqueue leaves after host accessor destruction #899
Conversation
|
LGTM. Please fix title: leaves-> leafs |
|
Could you please write a test which check that PI call which enqueues kernel is called during host accessor d'tor? |
It sounds like it is mostly leaves https://www.merriam-webster.com/dictionary/leaf Otherwise, I think that the Intel FPGA team is in Toronto... |
Yeah, you are right. |
KarachunIvan
force-pushed
the
private/ivankara/enqueue_leaves
branch
from
d57328b to
4945ae5
Compare
| @@ -0,0 +1,36 @@ | |||
| // RUN: %clangxx -fsycl %s -o %t.out | |||
| // RUN: env SYCL_DEVICE_TYPE=HOST %t.out | |||
There was a problem hiding this comment.
It seems run on host is not needed.
Need to enqueue all leaves of the graph to start execution after unblocking. Signed-off-by: Ivan Karachun <[email protected]>
Signed-off-by: Ivan Karachun <[email protected]>
Signed-off-by: Ivan Karachun <[email protected]>
KarachunIvan
force-pushed
the
private/ivankara/enqueue_leaves
branch
from
4945ae5 to
2a0b678
Compare
In most cases convert functions are translated to set of LLVM IR instructions but in case of saturated conversion or if conversion has rounding mode, the translation should go through SPIR-V friendly LLVM IR. Original commit: KhronosGroup/SPIRV-LLVM-Translator@9f3c10f
Need to enqueue all leaves of the graph to start
execution after unblocking.
Signed-off-by: Ivan Karachun [email protected]