[SYCL][USM] Fix CL_MEM_ALLOC_INFO_* macros in USM header #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenju-he
force-pushed
the
fix_usm_header
branch
from
2d49b32 to
8899cec
Compare
vladimirlaz
previously approved these changes
Oct 12, 2019
Fix CL_MEM_ALLOC_INFO_* macro and add const to properties arguments. Signed-off-by: Wenju He <[email protected]>
wenju-he
force-pushed
the
fix_usm_header
branch
from
8899cec to
c13e862
Compare
vladimirlaz
approved these changes
Oct 23, 2019
bader
changed the title
|
@jbrodman, does this change look fine to you? |
vladimirlaz
pushed a commit
to vladimirlaz/llvm
that referenced
this pull request
Sep 7, 2020
UIToFPInst LLVM instruction is translated to OpConvertUToF SPIRV instruction. OpConvertUToF instruction cannot receive boolean operand, so replace boolean operand with with select instruction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync macros with doc. @jbrodman please review.