Skip to content

[SYCL] Fix reductions regressions after #6343 #6460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2022
Merged

[SYCL] Fix reductions regressions after #6343 #6460

merged 1 commit into from
Jul 22, 2022

Conversation

aelovikov-intel
Copy link
Contributor

Three pieces:

  • Access to private static handler::withAuxHandler
  • Pow2WG -> HasUniformWG
  • Out accessor must be the last created (after other temps)

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner July 20, 2022 22:36
@aelovikov-intel
[SYCL] Fix reductions regressions after intel#6343
db56558 
Three pieces:

  * Access to private static handler::withAuxHandler
  * Pow2WG -> HasUniformWG
  * Out accessor must be the last created (after other temps)
aelovikov-intel added a commit to aelovikov-intel/llvm-test-suite that referenced this pull request Jul 20, 2022
@aelovikov-intel
[SYCL] Add regression test for intel/llvm#6460
ac6d743
@aelovikov-intel
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1106

@aelovikov-intel aelovikov-intel mentioned this pull request Jul 21, 2022
Merged
@aelovikov-intel
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1106

@aelovikov-intel
Copy link
Contributor Author

Unexpected Pass has nothing to do with reductions, @intel/llvm-gatekeepers , PR is ready.

@againull againull merged commit a0bfab1 into intel:sycl Jul 22, 2022
againull pushed a commit to intel/llvm-test-suite that referenced this pull request Jul 22, 2022
@aelovikov-intel
[SYCL] Add regression test for intel/llvm#6460 (#1106)
2466d1c
@aelovikov-intel aelovikov-intel deleted the red-fix-regression branch July 28, 2022 20:31
aelovikov-intel added a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@aelovikov-intel
[SYCL] Add regression test for intel#6460 (intel/llvm-test-suite#1106)
5a5c833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-semenov sergey-semenov sergey-semenov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelovikov-intel @sergey-semenov @againull