Pass new property list into USM malloc API #5666
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
------------------------------------------------ This is a temporary solution to passing buffer_location information onto runtime. Currently the function will support pass in of compiler properties, however it will not do anything with it. In full solution, an annotated pointer should be returned (rather than T*) to capture compile time information.
|
Do you plan to have a decorated pointer even on the host side to be captured on the device side? |
I believe the current decision is to let host malloc to capture only on host side. Buffer location is not restricted to just device memories location. However, note this is still being discussed, decision may change. |
|
Closing because superceeded by #5634 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary solution to passing buffer_location information onto runtime. Currently the function will support pass in of compiler properties, however it will not do anything with it.
In full solution, an annotated pointer should be returned (rather than T*) to capture compile time information.
This contains less throw away work than https://github.com/intel/llvm/pull/5665/files
The full solution should be #5656