[SYCL] Release global shared implementation pointers early #4786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the global handler keeps shared pointers to SYCL object implementations alive until an intentionally late destruction. Backends that rely on global state may destroy its global state prior to the global handler releasing its references to SYCL object implementations that are in turn keeping backend objects alive. These changes enforce a release of the global handler's references to globally tracked SYCL objects at regular global destructor time to avoid the objects unintentionally staying alive for too long. Signed-off-by: Steffen Larsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the global handler keeps shared pointers to SYCL object implementations alive until an intentionally late destruction. Backends that rely on global state may destroy its global state prior to the global handler releasing its references to SYCL object implementations that are in turn keeping backend objects alive.
These changes enforce a release of the global handler's references to globally tracked SYCL objects at regular global destructor time to avoid the objects unintentionally staying alive for too long.