[SYCL][Matrix] Add support for joint_matrix_mad when A is uint8/int8 … #4486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and B is uint8/int8 With this patch, more cases for C=A*B+C can be realized: 1. A is uint8, B is int8 2. A is int8, B is uint8 3. A is uint8, B is uint8
yubingex007-a11y
requested review from
bader,
dkhaldi,
MrSidims and
LuoYuanke
MrSidims
reviewed
Sep 3, 2021
1. Remove the newly-added testcases since we add them into llvm-test-suite 2. Remove "-march=sapphirerapids" from previous testcases
|
@dkhaldi @intel/llvm-reviewers-runtime Ping |
v-klochkov
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
Looks Good To Me. Merge is pending to resolution of #4486 (comment)
|
@bader ping? |
MrSidims
approved these changes
Sep 8, 2021
DoyleLi
pushed a commit
to DoyleLi/intel_llvm
that referenced
this pull request
Sep 13, 2021
…4486) With this patch, more cases for C=A*B+C can be realized: 1. A is uint8, B is int8 2. A is int8, B is uint8 3. A is uint8, B is uint8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and B is uint8/int8
With this patch, more cases for C=A*B+C can be realized: