Skip to content

[SYCL][CUDA] Windows and MSVC support for CUDA backend #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 13, 2021

Conversation

AidanBeltonS
Copy link
Contributor

Patch adds windows support for CUDA backend.

Adds general handling of Windows file paths
Windows support is enabled with remangling of variables from PR #4207 as it fixes mismatch between windows 32-bit longs and default 64-bit long and handles wchar_size.
Adds changes to account for MSVC's default to private classes.
Fixes to unittests for windows.

@bader bader added the cuda CUDA back-end label Aug 16, 2021
Signed-off-by: Steffen Larsen <[email protected]>
@codeplay-sycl codeplay-sycl force-pushed the steffen/windows-support branch from 4006563 to ff947d1 Compare August 16, 2021 13:27
bader
bader previously approved these changes Aug 19, 2021
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libclc changes look good to me. Just one minor suggestion.

@bader bader linked an issue Aug 20, 2021 that may be closed by this pull request
@bader
Copy link
Contributor

bader commented Aug 24, 2021

@AidanBeltonS, this change introduces a regression: http://ci.llvm.intel.com:8010/#/builders/37/builds/11953/steps/14/logs/FAIL__Clang__cuda-windows_cu. Could you take a look, please?

@AidanBeltonS
Copy link
Contributor Author

@AidanBeltonS, this change introduces a regression: http://ci.llvm.intel.com:8010/#/builders/37/builds/11953/steps/14/logs/FAIL__Clang__cuda-windows_cu. Could you take a look, please?

Yes, I can try and see what is causing it. Thanks

@AidanBeltonS
Copy link
Contributor Author

@AidanBeltonS, this change introduces a regression: http://ci.llvm.intel.com:8010/#/builders/37/builds/11953/steps/14/logs/FAIL__Clang__cuda-windows_cu. Could you take a look, please?

Added a fix for the cuda-windows.cu test. Hopefully it should run without error.

bader
bader previously approved these changes Aug 25, 2021
mdtoguchi
mdtoguchi previously approved these changes Aug 25, 2021
steffenlarsen
steffenlarsen previously approved these changes Aug 25, 2021
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've built and tested it on a Windows machine using MSVC and only 2 tests in the test suite (intel/llvm-test-suite#383 specifically) fail. I suggest we disregard those 2 tests until both this and intel/llvm-test-suite#383 is merged, then mark them as failing for the CUDA backend on Windows and make issues for each failing test.

Additions LGTM!

@bader
Copy link
Contributor

bader commented Sep 3, 2021

@smaslov-intel, @intel/llvm-reviewers-runtime, ping.

@AidanBeltonS, could you resolve merge conflict, please?

@AidanBeltonS
Copy link
Contributor Author

@AidanBeltonS, could you resolve merge conflict, please?

Conflict should be resolved now.

Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

@steffenlarsen
Copy link
Contributor

A new CUDA backend unittest has been added in sycl\unittests\pi\cuda\test_contexts.cpp. This will need the same treatment as the other unittests.

bader
bader previously approved these changes Sep 10, 2021
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader requested a review from mdtoguchi September 13, 2021 14:45
@bader bader merged commit 8aa3513 into intel:sycl Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CUDA] Experimental support for Windows ?
5 participants