-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][CUDA] Windows and MSVC support for CUDA backend #4345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Steffen Larsen <[email protected]>
4006563
to
ff947d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libclc
changes look good to me. Just one minor suggestion.
@AidanBeltonS, this change introduces a regression: http://ci.llvm.intel.com:8010/#/builders/37/builds/11953/steps/14/logs/FAIL__Clang__cuda-windows_cu. Could you take a look, please? |
Yes, I can try and see what is causing it. Thanks |
Added a fix for the cuda-windows.cu test. Hopefully it should run without error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've built and tested it on a Windows machine using MSVC and only 2 tests in the test suite (intel/llvm-test-suite#383 specifically) fail. I suggest we disregard those 2 tests until both this and intel/llvm-test-suite#383 is merged, then mark them as failing for the CUDA backend on Windows and make issues for each failing test.
Additions LGTM!
@smaslov-intel, @intel/llvm-reviewers-runtime, ping. @AidanBeltonS, could you resolve merge conflict, please? |
d250087
Conflict should be resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments
A new CUDA backend unittest has been added in sycl\unittests\pi\cuda\test_contexts.cpp. This will need the same treatment as the other unittests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Patch adds windows support for CUDA backend.
Adds general handling of Windows file paths
Windows support is enabled with remangling of variables from PR #4207 as it fixes mismatch between windows 32-bit longs and default 64-bit long and handles wchar_size.
Adds changes to account for MSVC's default to private classes.
Fixes to unittests for windows.