Skip to content

[SYCL][FPGA][NFC] LSU builtin test and documentation update #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2021

Conversation

aditikum
Copy link
Contributor

Updating documentation to reflect change to multi_ptr.
Updating test so it tests device, host ptrs as well as accessor method.

@aditikum aditikum requested review from a team as code owners April 14, 2021 18:56
@aditikum aditikum requested a review from romanovvlad April 14, 2021 18:56
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would like that @mlychkov takes a look as well.

Copy link
Contributor

@mlychkov mlychkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@aditikum
Copy link
Contributor Author

merged to get this change: #3578 and enable the checks to pass.

@aditikum
Copy link
Contributor Author

@bader Anything pending for the merge?

@bader
Copy link
Contributor

bader commented Apr 28, 2021

@intel/dpcpp-specification-reviewers team should approve the spec.
@mkinsner, could you take a look, please?

@bader bader merged commit 1269348 into intel:sycl Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants