Skip to content

[SYCL] Add implementation of kernel_bundle. Part 4 #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

romanovvlad
Copy link
Contributor

The patch:

  1. Adds minimal interfaces for SYCL2020 style exceptions
  2. Adds diagnostics in kernel_bundle related APIs
  3. Adds hash functions for new classes
  4. Refactors has_kernel_bundle API

The patch:
1. Adds minimal interfaces for SYCL2020 style exceptions
2. Adds diagnostics in kernel_bundle related APIs
3. Adds hash functions for new classes
4. Refactors has_kernel_bundle API
@romanovvlad romanovvlad requested review from kbobrovs and a team as code owners April 1, 2021 10:21
alexbatashev
alexbatashev previously approved these changes Apr 5, 2021
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sergey-semenov sergey-semenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kbobrovs
kbobrovs previously approved these changes Apr 5, 2021
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanovvlad romanovvlad removed the request for review from smaslov-intel April 6, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants