Skip to content

[ESIMD] Let ESIMD attributes not depend on -fsycl-explicit-simd #3446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

DenisBakhvalov
Copy link
Contributor

@DenisBakhvalov DenisBakhvalov commented Mar 30, 2021

This is one of the final patches to support mixing SYCL and ESIMD kernels.
In the end, we want to get rid of -fsycl-explicit-simd option and unify the two modes: regular SYCL and ESIMD.
This patch eliminates one of the dependencies on the -fsycl-explicit-simd flag, allowing to use ESIMD attributes without it.

@AaronBallman
Copy link
Contributor

I'd appreciate a bit more information about why the change is being made (added to the PR description so it goes into the commit message).

Are no tests impacted by this change? We should add test coverage to show this is explicitly supported.

@DenisBakhvalov
Copy link
Contributor Author

DenisBakhvalov commented Mar 30, 2021

I'd appreciate a bit more information about why the change is being made (added to the PR description so it goes into the commit message).

Are no tests impacted by this change? We should add test coverage to show this is explicitly supported.

Yes, sorry, will do. I just wanted to check the ESIMD on-GPU tests in the llvm-test-suite. I believe converting to draft will stop the CI, right?

@AaronBallman
Copy link
Contributor

I'd appreciate a bit more information about why the change is being made (added to the PR description so it goes into the commit message).
Are no tests impacted by this change? We should add test coverage to show this is explicitly supported.

Yes, sorry, will do. I just wanted to check the ESIMD on-GPU tests in the llvm-test-suite. I believe converting to draft will stop the CI, right?

Good question! I think converting to a draft still runs the CI pipeline but I'm not 100% sure.

@DenisBakhvalov DenisBakhvalov requested a review from kbobrovs March 30, 2021 18:34
Copy link
Contributor

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denis, can you please update the docs too - the ESIMD intro and spec.

@DenisBakhvalov
Copy link
Contributor Author

Denis, can you please update the docs too - the ESIMD intro and spec.

I will. Is it OK if I update the docs in a separate patch once all the changes regarding SYCL-ESIMD coexistence will be done?

@kbobrovs
Copy link
Contributor

Denis, can you please update the docs too - the ESIMD intro and spec.

I will. Is it OK if I update the docs in a separate patch once all the changes regarding SYCL-ESIMD coexistence will be done?

Yes, that should be Ok

Copy link
Contributor

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants