[SYCL] Runtime property lists on kernel invocation functions #3416
Conversation
Add an optional parameter to kernel invocation functions which accepts property list. Such properties are going to affect the way the kernel is invoked. Example is a property to set cache/SLM size for a kernel invocation which is going to be implemented in upcoming PR.
|
I would suggest to be careful with adding more overloads to the kernel invocation functions for this functionality. They are already exceedingly complicated because of reductions, and I expect they will become even more complicated in the future with the addition of a library-only capable replacement mechanism for kernel attributes. This also retains the current convention that the kernel always comes as last argument of the invocation function, which I personally prefer for aesthetic reasons ;) |
| // CHECK-NEXT: | [sizeof=560, dsize=560, align=8, | ||
| // CHECK-NEXT: | nvsize=560, nvalign=8] |
There was a problem hiding this comment.
Isn't breaking ABI avoidable?
Tagging @romanovvlad .
There was a problem hiding this comment.
Yeah, Artur, please avoid breaking ABI. Similar problem is being solved here: #3375
|
This PR is going to be redone. |
Add an optional parameter to kernel invocation functions which accepts
property list. Such properties are going to affect the way the kernel
is invoked. Example is a property to set cache/SLM size for a kernel
invocation which is going to be implemented in upcoming PR.
Test: intel/llvm-test-suite#197
Draft PR for GPU Cache Config property: #3417