-
Notifications
You must be signed in to change notification settings - Fork 790
[SYCL][NFC] Remove some work-arounds for C++11 #3168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
C++14 is required after intel#3053 Thus some of C++11 workarounds in the code became unnecessary. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
de41532
to
d96ecbe
Compare
What about similar work-arounds in other files (e.g. accessor.hpp, buffer.hpp, etc.)? |
@v-klochkov, do you have plans on type traits' refactoring in scope of this shift, or is this something I could volunteer for instead of finalizing #2778? |
@bader, This fix removes only some workarounds, not all of them. In particular it removes a bit more than was promised here: #2528 (review) |
@AGindinson , Sure, you can volunteer to do more code cleanup. With C++14 sycl::detail::enable_if_t can be replaced with std::enable_if_t, etc.. |
That was my question. Why do we remove only some workarounds and not all of them? |
There is no rush here. Having everything in one change would require a huge patch, which then would suffer from conflicts, etc. In this patch I changed only places with "#if __cplusplus >= 201402L" |
C++14 is required after intel#3053 Thus some of C++11 workarounds in the code became unnecessary. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
- Wrong comment syntax for used - Fixed return for Get commit sha job Signed-off-by: Sidorov, Dmitry <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@c3b1fcd7726ae0c
C++14 is required after #3053
Thus some of C++11 workarounds in the code became unnecessary.
Signed-off-by: Vyacheslav N Klochkov [email protected]