[SYCL] Use a copy to avoid invalidated access #2495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug introduced in PR intel#2430 where the iterator might get invalidated between accesses. Signed-off-by: Premanand M Rao <[email protected]>
premanandrao
requested review from
elizabethandrews and
Fznamznon
as code owners
|
Change looks ok but can you explain what was wrong with the old code? I don't get why that doesn't work |
In between the first access of DDI->second and subsequent accesses the container that DDI points to changes. This shows up with the Windows library implementation (but not the Linux implementation). As a result when subsequently accessed, it results in an access violation. |
elizabethandrews
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in PR #2430 where the iterator
might get invalidated between accesses.
Signed-off-by: Premanand M Rao [email protected]