[Driver][SYCL][FPGA] Improve help output for aoc with -fsycl-help #2446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoc provides a way to emit SYCL FPGA specific options with the -help via the -sycl option. Augment the the help output behaviors to allow for an additional option that can be used with the tools.
AGindinson
approved these changes
Sep 11, 2020
Comment on lines
+1829
to
+1831
| llvm::errs() << "\"" << ExecPath << "\" \"" << ToolArgs[1] << "\""; | ||
| if (!ToolArgs[2].empty()) | ||
| llvm::errs() << " \"" << ToolArgs[2] << "\""; |
There was a problem hiding this comment.
Technically, a while loop would've looked cleaner than a hardcoded [2]. But I see why one can prefer the code this way (to avoid extra complexity in an unlikely-to-change helper function).
There was a problem hiding this comment.
I could go either way. It was just a single argument used in a very specific output function with know limited array args.
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[L0 v2] add missing catches to usm functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aoc provides a way to emit SYCL FPGA specific options with the -help
via the -sycl option. Augment the the help output behaviors to
allow for an additional option that can be used with the tools.