Skip to content

[SYCL] Refactor HW targeted extensions into the INTEL namespace #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 17, 2020

Conversation

jbrodman
Copy link
Contributor

@jbrodman jbrodman commented Aug 3, 2020

Partners with #2239

This moves hardware focused extensions into the INTEL namespace.

It includes:
FPGA device selector, lsu, reg, and data flow pipes.
ESIMD

Signed-off-by: James Brodman [email protected]

@jbrodman jbrodman requested review from bader, MrSidims and a team as code owners August 3, 2020 14:40
@jbrodman jbrodman requested a review from sergey-semenov August 3, 2020 14:40
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
Signed-off-by: James Brodman <[email protected]>
@jbrodman
Copy link
Contributor Author

jbrodman commented Aug 3, 2020

Gah the backwards compat aliases for fpga break the build on windows b/c "intel" == "INTEL". 😵

@jbrodman jbrodman changed the title [SYCL][WIP] Refactor HW targeted extensions into the INTEL namespace [SYCL]Refactor HW targeted extensions into the INTEL namespace Aug 4, 2020
@jbrodman jbrodman changed the title [SYCL]Refactor HW targeted extensions into the INTEL namespace [SYCL] Refactor HW targeted extensions into the INTEL namespace Aug 4, 2020
@jbrodman
Copy link
Contributor Author

jbrodman commented Aug 5, 2020

All tests pass, @bader @MrSidims @sergey-semenov @intel/llvm-reviewers-runtime

@bader
Copy link
Contributor

bader commented Aug 5, 2020

/summary:run

@bader bader requested a review from GarveyJoe August 5, 2020 20:18
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLVM changes LGTM.
@GarveyJoe, FYI.

Copy link
Contributor

@sergey-semenov sergey-semenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbrodman
Copy link
Contributor Author

jbrodman commented Aug 6, 2020

Ping @MrSidims

@jbrodman jbrodman requested review from bader and MrSidims August 17, 2020 16:59
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bader bader merged commit 3084982 into intel:sycl Aug 17, 2020
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
[spec][usm-p2p] p2p info query return int instead of uint32_t, fix l0 impl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants