[SYCL][L0] Implement pi_device and pi_platform cache #2227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Byoungro So <[email protected]>
added piPlatformRelease to invalidate platforms when platform_impl is deallocated. Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
added piPlatformRelease to invalidate platforms when platform_impl is deallocated. Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
romanovvlad
reviewed
Aug 3, 2020
keryell
reviewed
Aug 3, 2020
|
@smaslov-intel please review. Thanks. |
keryell
reviewed
Aug 4, 2020
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
|
@bader @DoyleLi Again the failure in barrier.cpp already occurs in the sycl branch. |
smaslov-intel
suggested changes
Aug 5, 2020
Signed-off-by: Byoungro So <[email protected]>
|
@smaslov-intel , I accommodated your feedback and revised the PR. please review. Thanks |
Signed-off-by: Byoungro So <[email protected]>
also, reverted device_imple destructor change because it caused bugs. Signed-off-by: Byoungro So <[email protected]>
bso-intel
commented
Aug 6, 2020
bso-intel
commented
Aug 6, 2020
Signed-off-by: Byoungro So <[email protected]>
|
@smaslov-intel I have accommodated your feedback. Please review. |
Signed-off-by: Byoungro So <[email protected]>
romanovvlad
previously approved these changes
Aug 10, 2020
Signed-off-by: Byoungro So <[email protected]>
smaslov-intel
suggested changes
Aug 10, 2020
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
smaslov-intel
previously approved these changes
Aug 11, 2020
Signed-off-by: Byoungro So <[email protected]>
romanovvlad
approved these changes
Aug 12, 2020
smaslov-intel
approved these changes
Aug 12, 2020
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Handle INVALID_VALUE in OCL urPlatformGet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation piDevicesGet and piPlatformsGet always create new pi_device and pi_platform object even if the low-level ze_handles are the same.
This makes SYCL RT difficult to determine whether sycl::device is the same.
Same issue applies to sycl::platform.
By implementing cache, it can avoid calling expensive L0 RT and return the saved pi_device and pi_platform from the cache.
This should help remove the memory leak and improve the overall performance of plugins.